Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better logging for Graphsync traversal #167

Merged
merged 4 commits into from
Apr 26, 2021
Merged

Better logging for Graphsync traversal #167

merged 4 commits into from
Apr 26, 2021

Conversation

aarshkshah1992
Copy link
Contributor

No description provided.

@aarshkshah1992 aarshkshah1992 changed the base branch from master to release/0.6.x April 26, 2021 12:22
dirkmc
dirkmc reviewed Apr 26, 2021
View reviewed changes
Copy link
Collaborator

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits but otherwise looks good.
Should we also add debug logs for when we're about to load a link so that we can see all the CIDs of successfully loaded links?

responsemanager/runtraversal/runtraversal.go Outdated Show resolved Hide resolved
responsemanager/runtraversal/runtraversal.go Outdated Show resolved Hide resolved
@dirkmc
Copy link
Collaborator

dirkmc commented Apr 26, 2021

Also it seems like TestNetworkErrors/network_error_block_send is failing - I ran it again and the same test failed.

@aarshkshah1992
Copy link
Contributor Author

aarshkshah1992 commented Apr 26, 2021 •
edited
Loading

@dirkmc

Have added the debug logs.

That test is a flaky. See the same failure on master

aarshshah@Aarshs-MacBook-Pro responsemanager % go test -count=100 -failfast -run TestNetworkErrors
go: downloading github.com/ipld/go-ipld-prime v0.9.1-0.20210324083106-dc342a9917db
go: downloading github.com/ipld/go-codec-dagpb v1.2.0
go: downloading github.com/multiformats/go-multihash v0.0.15
go: downloading github.com/minio/sha256-simd v1.0.0
go: downloading golang.org/x/crypto v0.0.0-20210220033148-5ea612d1eb83
go: downloading github.com/klauspost/cpuid/v2 v2.0.4
go: downloading golang.org/x/sys v0.0.0-20210309074719-68d13333faf2
--- FAIL: TestNetworkErrors (10.01s)
    --- FAIL: TestNetworkErrors/network_error_block_send (10.00s)
        channelassertions.go:72: 
            	Error Trace:	channelassertions.go:72
            	            				channelassertions.go:48
            	            				responsemanager_test.go:1037
            	            				responsemanager_test.go:629
            	Error:      	Not equal: 
            	            	expected: 0
            	            	actual  : 1
            	Test:       	TestNetworkErrors/network_error_block_send
            	Messages:   	should clear request
FAIL
exit status 1
FAIL	github.com/ipfs/go-graphsync/responsemanager	21.346s
aarshshah@Aarshs-MacBook-Pro responsemanager % git status
On branch master
Your branch is up to date with 'origin/master'.

@dirkmc dirkmc merged commit fee8141 into release/0.6.x Apr 26, 2021
@dirkmc dirkmc deleted the fix/log-blockstore-reads branch April 26, 2021 14:23
@dirkmc dirkmc mentioned this pull request Apr 27, 2021
Merged
@dirkmc dirkmc mentioned this pull request Jun 10, 2021
Merged
hannahhoward added a commit that referenced this pull request Aug 5, 2021
@hannahhoward @dirkmc @aarshkshah1992
Merge the v0.6.x commit history (#190)
d60a91f 
* feat: fire network error when network disconnects during request (#164)

* release: 0.6.1

* Better logging for Graphsync traversal (#167)

* log gs traversal

* Apply suggestions from code review

Co-authored-by: dirkmc <dirkmdev@gmail.com>

* add debug logs

* add debug logs

Co-authored-by: dirkmc <dirkmdev@gmail.com>

* release: v0.6.2 (#168)

* Fix/log blockstore reads (#169)

* log gs traversal

* Apply suggestions from code review

Co-authored-by: dirkmc <dirkmdev@gmail.com>

* add debug logs

* fixed logging

* Apply suggestions from code review

Co-authored-by: dirkmc <dirkmdev@gmail.com>

* fixed error

Co-authored-by: dirkmc <dirkmdev@gmail.com>

* release: v0.6.3 (#170)

* request queued hook

* test request queued hook

* release: v0.6.4

* Resolve 175 race condition, no change to hook timing (#178)

* feat(requestmanager): add request timing (#181)

* Add cancel request and wait function (#185)

* fix(responsemanager): fix error codes (#182)

enforce much tighter consistency with graphsync spec in usage of error codes

* refactor: replace particular request not found errors with public error (#188)

* release: 0.6.8

Co-authored-by: dirkmc <dirkmdev@gmail.com>
Co-authored-by: Aarsh Shah <aarshkshah1992@gmail.com>
marten-seemann pushed a commit that referenced this pull request Mar 2, 2023
@dirkmc
release: v1.2.9 (#167)
bd97d64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkmc dirkmc dirkmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aarshkshah1992 @dirkmc